Handle reverse conditions in isOppositeCond function#8408
Open
francois-berder wants to merge 2 commits intodanmar:mainfrom
Open
Handle reverse conditions in isOppositeCond function#8408francois-berder wants to merge 2 commits intodanmar:mainfrom
francois-berder wants to merge 2 commits intodanmar:mainfrom
Conversation
Signed-off-by: Francois Berder <fberder@outlook.fr>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
danmar
reviewed
Apr 8, 2026
| static bool isZeroBoundCond(const Token * const cond, bool reverse) | ||
| { | ||
| if (cond == nullptr) | ||
| if (cond == nullptr || cond->astOperand1() == nullptr || cond->astOperand2() == nullptr) |
Owner
There was a problem hiding this comment.
Suggested change
| if (cond == nullptr || cond->astOperand1() == nullptr || cond->astOperand2() == nullptr) | |
| if (cond == nullptr || !cond->isBinaryOp()) |
| return !isZero; | ||
| if (cond->str() == ">") | ||
|
|
||
| if ((reverse && !cond->astOperand1()->hasKnownIntValue()) || (!reverse && !cond->astOperand2()->hasKnownIntValue())) |
Owner
There was a problem hiding this comment.
hmm an alternative that would lead to less "hard coding" would be:
std::string cmp = cond->str();
if (reverse && cmp[0] == '>')
cmp[0] = '<';
else if (reverse && cmp[0] == '<')
cmp[0] = '>';
const Token* const op1 = reverse ? cond->astOperand1() : cond->astOperand2();
const Token* const op2 = reverse ? cond->astOperand2() : cond->astOperand1();
....
Collaborator
|
Please file a ticket for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.